feat(matching): use ShardProcessors instead of TaskListManagers#7480
Merged
eleonoradgr merged 1 commit intocadence-workflow:masterfrom Dec 1, 2025
Merged
Conversation
eleonoradgr
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Signed-off-by: edigregorio <edigregorio@uber.com>
eleonoradgr
force-pushed
the
basic-integration
branch
from
dc91b29 to
4773e0e
Compare
eleonoradgr
commented
Nov 28, 2025
| taskListsLock sync.RWMutex // locks mutation of taskLists | ||
| taskLists map[tasklist.Identifier]tasklist.ShardProcessor // Convert to LRU cache | ||
| executor executorclient.Executor[tasklist.ShardProcessor] | ||
| taskListsFactory *tasklist.ShardProcessorFactory |
Contributor
Author
There was a problem hiding this comment.
This is going to disappear in the next diff, it is just going to be part of the executor, but now it is for visibility and how it is instanciated
jakobht
approved these changes
Nov 28, 2025
|
|
||
| currentTlMgr, ok := e.taskLists[*id] | ||
| if ok && tlMgr == currentTlMgr { | ||
| if ok && currentTlMgr.String() == tlMgr.String() { |
Member
There was a problem hiding this comment.
Doing .String here is quite opaque. It's hard to tell what exactly is being compared without going to the implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
The executor library is using the concept of shardProcessor to monitor a shard, in the case of matching a shardProcessor can be seen as a task executor manager.
The change in the executor library is necessary because moving the logic from the
How did you test it?
tested locally and with unit tests
Potential risks
matching service could be affected since we are changing the way we create new tasks.
Release notes
Documentation Changes